Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine subtests of test_publish_and_manipulate #964

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 19, 2022

Part of #946.

This reduces the runtime of the test from 14.49s to 9.82s.

@jwodder jwodder added the tests Add or improve existing tests label Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #964 (451ed90) into master (b890375) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   87.58%   87.56%   -0.03%     
==========================================
  Files          65       65              
  Lines        8119     8104      -15     
==========================================
- Hits         7111     7096      -15     
  Misses       1008     1008              
Flag Coverage Δ
unittests 87.56% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef64288...451ed90. Read the comment docs.

@yarikoptic
Copy link
Member

I haven't done careful analysis if all testing is preserved but looks kosher.

coolio, thanks @jwodder .

@yarikoptic yarikoptic merged commit 00ee4dd into master Apr 19, 2022
@yarikoptic yarikoptic deleted the gh-946 branch April 19, 2022 18:08
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants