ENH: log dandischema version and ensure we log (consistently) path for log messages in download #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r log messages in download
yarikoptic
added
DX
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1499 +/- ##
==========================================
- Coverage 88.51% 88.17% -0.35%
==========================================
Files 77 77
Lines 10572 10671 +99
==========================================
+ Hits 9358 9409 +51
- Misses 1214 1262 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…with or without exception etc
…message while at it
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
asmacdo
reviewed
Sep 13, 2024
| else: | ||
| lgr.debug( | ||
| "Download directory found, but digests do not match; starting new download" | ||
| "%s - download directory found, but digests do not match;" | ||
| " starting new download", |
There was a problem hiding this comment.
Would digests.keys() and self. digests.keys() be useful to know here?
There was a problem hiding this comment.
I felt like I wondered the same and then dismissed as it would be "too much noise". but now not sure -- it might be... yet to decide
Also shortened the log line to not include traceback
…(via inode matching)
not sure why was not failing for me locally but fails on CI
That is my guess for what is happening in
________________________ test_DownloadDirectory_basic _________________________
dandi\tests\test_download.py:1048: in test_DownloadDirectory_basic
with DownloadDirectory(tmp_path, digests={}) as dl:
dandi\download.py:889: in __exit__
self.writefile.replace(self.filepath)
C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\pathlib.py:1247: in replace
self._accessor.replace(self, target)
E PermissionError: [WinError 5] Access is denied: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0.dandidownload\\file' -> 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0'
| @@ -853,12 +869,35 @@ def __exit__( | |||
| exc_tb: TracebackType | None, | |||
| ) -> None: | |||
| assert self.fp is not None | |||
| if exc_type is not None or exc_val is not None or exc_tb is not None: | |||
There was a problem hiding this comment.
exc_tb is not used in the log here.
There was a problem hiding this comment.
first I had it but then kicked out from actual log -- the point is that if any of them provided, exception happened.
Very unlikely but it could be that directory already existed but without checksum file for some reason.
no v prefix since is not providing any information on top; sorting for deterministic order
…th was set to default to True
…IVE_RETRY mode This is all to address that odd case with 000026 where connection keeps interrupting. Unclear why so adding more specific cases handling and allowing for such an aggressive retrying where we would proceed as long as we are getting something (but sleep would also increase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully would be in assist to troubleshoot issues with downloads, like the one now reported by @Kevancic on slack