Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_server_info failing due to no good version provided #976

Closed
yarikoptic opened this issue Apr 21, 2022 · 5 comments · Fixed by #978
Closed

test_server_info failing due to no good version provided #976

yarikoptic opened this issue Apr 21, 2022 · 5 comments · Fixed by #978
Assignees
Labels

Comments

@yarikoptic
Copy link
Member

now that there is no redirector with hardcoded version and version is reported of dandi-archive itself we hit good old dandi/dandi-archive#222 leading to

_______________________________ test_server_info _______________________________
dandi/tests/test_utils.py:321: in test_server_info
    assert Version(data["version"]) >= Version("1.2.0")
/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/semantic_version/base.py:105: in __init__
    major, minor, patch, prerelease, build = self.parse(version_string, partial)
/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/semantic_version/base.py:311: in parse
    raise ValueError('Invalid version string: %r' % version_string)
E   ValueError: Invalid version string: '0+unknown'

dandi/dandi-archive#1054 might be the one to resolve it for the main deployments but I don't know if it would apply to our dockerized server testing since it hardcodes to 0.0.0 in https://github.com/dandi/dandi-archive/pull/1054/files#diff-8fbdfcdd92c90a7625fcf215e3b363869ff8ce725869824d28380b863498d35dR14

@jwodder
Copy link
Member

jwodder commented Apr 21, 2022

@yarikoptic That test is not run against the local Docker setup. The references to Docker in the test's code are for the integration tests with the old redirector.

@yarikoptic
Copy link
Member Author

so you think test would pass after dandi/dandi-archive#1054 merged/deployed?

since placing into production would take time, should we just for now mark it as xfail and then reenable after deployed?

@jwodder
Copy link
Member

jwodder commented Apr 21, 2022

@yarikoptic

so you think test would pass after dandi/dandi-archive#1054 merged/deployed?

Yes.

since placing into production would take time, should we just for now mark it as xfail and then reenable after deployed?

You tell me.

@yarikoptic
Copy link
Member Author

if you have no opinion, then let's indeed proceed with mine of xfail.

yarikoptic added a commit that referenced this issue Apr 21, 2022
Mark `test_server_info` as xfailing
@github-actions
Copy link

🚀 Issue was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants