Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Memory allocation error on Windows #1906

Closed
ofek opened this issue Nov 13, 2024 · 3 comments
Closed

🐛 Memory allocation error on Windows #1906

ofek opened this issue Nov 13, 2024 · 3 comments

Comments

@ofek
Copy link

ofek commented Nov 13, 2024

Delta: 0.18.2
Windows: 11

The recommended solution in the other issues does not work because building triggers the same behavior. Can nothing be done to fix this permanently on Delta's side?

image

@dandavison
Copy link
Owner

dandavison commented Nov 14, 2024

Hi @ofek. Is the problem here that your bat version is creating binary assets that are incompatible with delta? Can you post your bat version and try upgrading bat?

Delta uses the syntax-highlighting assets maintained by the bat project; I think that's fairly set in stone -- it's very valuable hard work done by the bat team and we don't want to maintain a fork of them. By default this works without risk for delta, since the assets are installed as a library. However when building custom assets (which uses the bat toolchain) there is a risk of version clashes.

Perhaps there is a development path in which delta adds its own asset-building toolchain, (essentially copied from bat), while continuing to share the asset repository, and delta thus uses a separate on-disk location for the assets.

@ofek
Copy link
Author

ofek commented Nov 14, 2024

My apologies, indeed upgrading bat resolved the issue. Thank you!

@dandavison
Copy link
Owner

No problem! We should maybe have a "troubleshooting" section in the manual with if-this-then-maybe-that recipes. But I'm inclined to think the best solution is for someone to continue the delta doctor work started in #1193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants