Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make presetConfiguration Apply to userInput As well #63

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

rougegoat
Copy link
Contributor

Modify the configurationJSON section so that it is hidden if presetConfiguration has been set.

modify the section pulling in User Input so that it will pull in the presetConfiguration if set.

This allows the presetConfiguration value to be applied when welcomeDialog is set to userInput.

Modify the configurationJSON section so that it is hidden if presetConfiguration has been set.

modify the section pulling in User Input so that it will pull in the presetConfiguration if set.

This allows the presetConfiguration value to be applied when welcomeDialog is set to userInput.
@dan-snelson dan-snelson changed the base branch from main to development May 24, 2023 17:06
@dan-snelson
Copy link
Collaborator

Thanks, as always, @rougegoat!

@dan-snelson dan-snelson self-assigned this May 24, 2023
@dan-snelson dan-snelson added this to the 1.11.1 milestone May 24, 2023
@dan-snelson dan-snelson added the enhancement New feature or request label May 24, 2023
@dan-snelson dan-snelson changed the base branch from development to 1.12.0 June 5, 2023 10:05
@dan-snelson dan-snelson merged commit f5c2867 into setup-your-mac:1.12.0 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants