Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Test the network speed/stability when you run SYM #7

Closed
DevliegereM opened this issue Mar 9, 2023 · 5 comments
Closed

Feature Request: Test the network speed/stability when you run SYM #7

DevliegereM opened this issue Mar 9, 2023 · 5 comments
Assignees
@dan-snelson
Labels
enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor
Milestone
1.10.0

Comments

@DevliegereM
Copy link

Note: While all requests are welcome, finding available cycles to custom-code a feature we won't use in our production environment is always challenging.

Is your feature request related to a problem? Please describe.
No, not a problem

Describe the solution you'd like
Depending on the score you can define which enrolment needs to happen? (basic/recommended/complete). You could even go as far as to let the admins decide what defines a good score (download speed/upload speed/network range/...) and have that defined inside SYM.

Describe alternatives you've considered
Running networkQuality to determine the speed and get the value from the result.
Running speedtest-cli, but that depends on brew already being installed (more overhead)

Additional context
No, just an idea that popped up in my head when playing with 1.8.0.
@DevliegereM DevliegereM added the enhancement New feature or request label Mar 9, 2023
@dan-snelson
Copy link
Collaborator

Thanks for the FR, @DevliegereM!

A trio of networkQuality EAs

This might be too much overhead, but what if we looked at “Download Responsiveness” and .PKG size and then provided a rough estimate of the additional time required for any Configuration beyond “Required” ?

(Probably add yet another case statement with filesize estimates for each Configuration.)

@dan-snelson dan-snelson added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 9, 2023
@dan-snelson dan-snelson changed the title Test the network speed/stability when you run SYM Feature Request: Test the network speed/stability when you run SYM Mar 9, 2023
@dan-snelson dan-snelson added this to the 1.10.0 milestone Mar 30, 2023
dan-snelson added a commit that referenced this issue Apr 7, 2023
@dan-snelson
1.10.0-rc3
64d3711 
06-Apr-2023

- 🆕 **Configuration Download Estimate** (Addresses [Issue No. 7]((#7)); thanks for the idea, @DevliegereM; heavy-lifting provided by @bartreardon!)
  - Manually set `configurationDownloadEstimation` within the script to `true` to enable
  - Specify an arbitrary value for `correctionCoefficient` (i.e., a "fudge factor" to help estimates match reality)
  - Calculate total file size (in MB) for each Configuration, then populate:
    - `configurationOneSize`
    - `configurationTwoSize`
    - `configurationThreeSize`
- 🔥 **Breaking Change** for users of Setup Your Mac prior to `1.10.0` 🔥
  - Added `recon` validation, which **must** be used when specifying the `recon` trigger (Addresses [Issue No. 19](#19))
- Standardized formatting of `toggleJamfLaunchDaemon` function
- Limit the `loggedInUserFirstname` variable to `25` characters and capitalize its first letter (Addresses [Issue No. 20](#20); thanks @mani2care!)
- Added line break to `welcomeTitle` and `welcomeBannerText`
- Replaced some generic "Mac" instances with hardware-specific model name (thanks, @Pico!)
- Replaced `verbose` Debug Mode code with `outputLineNumberInVerboseDebugMode` function (thanks, @bartreardon!)
- Removed dependency on `dialogApp`
@dan-snelson
Copy link
Collaborator

@DevliegereM:

Please test-drive 1.10.0-rc3:

1.10.0

Release Date TBD

  • 🆕 Configuration Download Estimate (Addresses Issue No. 7; thanks for the idea, @DevliegereM; heavy-lifting provided by @bartreardon!)
    • Manually set configurationDownloadEstimation within the script to true to enable
    • Specify an arbitrary value for correctionCoefficient (i.e., a "fudge factor" to help estimates match reality)
    • Calculate total file size (in MB) for each Configuration, then populate:
      • configurationOneSize
      • configurationTwoSize
      • configurationThreeSize

@dan-snelson dan-snelson added waiting feedback Waiting on feedback from requestor and removed help wanted Extra attention is needed labels Apr 7, 2023
dan-snelson added a commit that referenced this issue Apr 10, 2023
@dan-snelson
1.10.0-rc6
0f92515 
10-Apr-2023
- 🆕 **Configuration Download Estimate** (Addresses [Issue No. 7]((#7)); thanks for the idea, @DevliegereM; heavy-lifting provided by @bartreardon!)
    - Manually set `configurationDownloadEstimation` within the SYM script to `true` to enable
    - New `calculateFreeDiskSpace` function will record free space to `scriptLog` before and after SYM execution
        - Compare before and after free space values via: `grep "free" $scriptLog`
    - Populate the following variables, in Gibibits (i.e., Total File Size in Gigabytes * 7.451), for each Configuration:
        - `configurationOneSize`
        - `configurationTwoSize`
        - `configurationThreeSize`
    - Specify an arbitrary value for `correctionCoefficient` (i.e., a "fudge factor" to help estimates match reality)
        - Validate actual elapsed time with: `grep "Elapsed" $scriptLog`
- 🔥 **Breaking Change** for users of Setup Your Mac prior to `1.10.0` 🔥
    - Added `recon` validation, which **must** be used when specifying the `recon` trigger (Addresses [Issue No. 19](#19))
- Standardized formatting of `toggleJamfLaunchDaemon` function
- Limit the `loggedInUserFirstname` variable to `25` characters and capitalize its first letter (Addresses [Issue No. 20](#20); thanks @mani2care!)
- Added line break to `welcomeTitle` and `welcomeBannerText`
- Replaced some generic "Mac" instances with hardware-specific model name (thanks, @Pico!)
- Replaced `verbose` Debug Mode code with `outputLineNumberInVerboseDebugMode` function (thanks, @bartreardon!)
- Removed dependency on `dialogApp`
- Check `bannerImage` and `welcomeBannerImage` ([Pull Request No. 22](#22); thanks @amadotejada!)
@DevliegereM
Copy link
Author

Tested it and it works flawlessly if you use any of the three configurations.
In production however we only use the catch-all since we deliver our macbooks to only have the basic of security tools and whatever department ends up using it they have their own follow up to do.
It would be nice to have an estimated time left in the policy screen :)

@dan-snelson
Copy link
Collaborator

Excellent feedback, @DevliegereM.

I’ll take a look.

@dan-snelson
Copy link
Collaborator

Thanks, @DevliegereM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-snelson dan-snelson

Labels
enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
2 participants
@DevliegereM @dan-snelson