Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add Configuration to the help (?) button output for help #17

Closed
master-vodawagner opened this issue Mar 21, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor
Milestone

Comments

@master-vodawagner
Copy link

Note: While all requests are welcome, finding available cycles to custom-code a feature we won't use in our production environment is always challenging.

Is your feature request related to a problem? Please describe.
No, just extends an existing feature

Describe the solution you'd like
Hey @dan-snelson

Just a simple FR I believe, would be good to add the chosen configuration to the help ? button which offers the computer information

Describe alternatives you've considered
None

Additional context
Add any other context or screenshots about the feature request here.

Copy link
Collaborator

Great idea!

@dan-snelson
Copy link
Collaborator

@master-vodawagner:

Looks like this will have to wait for a possible update to swiftDialog; see swiftDialog Issue No. 248.

# New code, starting around Line No. 2267

# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
# Update Setup Your Mac's helpmessage
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

# Output Line Number in `verbose` Debug Mode
if [[ "${debugMode}" == "verbose" ]]; then updateScriptLog "# # # SETUP YOUR MAC VERBOSE DEBUG MODE: Line No. ${LINENO} # # #" ; fi

if [[ -n ${infoboxConfiguration} ]]; then

    updateScriptLog "Update 'helpmessage' with Configuration: ${infoboxConfiguration} …"

    helpmessage="If you need assistance, please contact the Global Service Department:  \n- **Telephone:** +1 (801) 555-1212  \n- **Email:** support@domain.org  \n- **Knowledge Base Article:** KB0057050  \n\n**Configuration:** \n- ${infoboxConfiguration}  \n\n**Computer Information:**  \n- **Operating System:**  ${macOSproductVersion} (${macOSbuildVersion})  \n- **Serial Number:** ${serialNumber}  \n- **Dialog:** ${dialogVersion}  \n- **Started:** ${timestamp}"
    
fi

dialogUpdateSetupYourMac "helpmessage: ${helpmessage}"

@dan-snelson dan-snelson added the on-hold On-hold, pending external label Mar 28, 2023
@dan-snelson dan-snelson added this to the 1.10.0 milestone Mar 30, 2023
@dan-snelson
Copy link
Collaborator

@master-vodawagner:

This has been added to 1.10.0-rc13 (and requires swiftDialog v2.2).

@dan-snelson dan-snelson added waiting feedback Waiting on feedback from requestor and removed on-hold On-hold, pending external labels Apr 20, 2023
@dan-snelson
Copy link
Collaborator

Thanks, @master-vodawagner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor
Projects
None yet
Development

No branches or pull requests

2 participants