Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/export of maps do not retain style. #32

Closed
damonsk opened this issue Dec 30, 2019 · 5 comments
Closed

Download/export of maps do not retain style. #32

damonsk opened this issue Dec 30, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@damonsk
Copy link
Owner

damonsk commented Dec 30, 2019

when using
style handwritten
or
style wardley
and downloading maps, the style is lost.

@damonsk damonsk added the bug Something isn't working label Dec 30, 2019
@ShaunBulbrook
Copy link
Contributor

I've noticed that the fonts also drop here.
I might have a quick fix for this one will see if I can get it done before I leave the office tonight.

@ShaunBulbrook
Copy link
Contributor

Hmm
Sadly my quick fix was not to be.

I need to do a bit of reading up on font family use in SVGs and re-check over the supported properties of html2canvas.
I have a WIP branch that might nudge someone in the right direction in the interim. (This is very much experimental, the way the styles are applied in that branch are not at all maintainable!)
ShaunBulbrook#1

^ In the example above the wardley style renders with the same font I see in the browser. (except for text-transform) - No change to the hand-written font (Potentially because it is loaded from a 3rd party)

@damonsk
Copy link
Owner Author

damonsk commented Dec 30, 2019

had a look around - stumbled upon this: niklasvh/html2canvas#1709 (comment)

I've done a few inline with your draft to try and make it more maintainable.

@ShaunBulbrook
Copy link
Contributor

Amazing! Shout if there's anything you need!

@ChristianDavis
Copy link
Contributor

I think you can close this one

@damonsk damonsk closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants