modtimidepsv doublecasting and update

[jchylik]

There are two issues in modtimedepsv. The first one is that it is casting the same variable twice, but with a seemingly different array length.

l.152, 154:

    call MPI_BCAST(timesvz(1:kflux),kflux,MY_REAL,0,comm3d,mpierr)
    call MPI_BCAST(svst             ,kflux*nsv,MY_REAL,0,comm3d,mpierr)
    call MPI_BCAST(timesvz(1:kls)    ,kls,MY_REAL  ,0,comm3d,mpierr)

The second line is indeed correct. Surprisingly, it does not crash.
This is due to the fact that kls and kflux are both currently parameters set to the length 100. While this approach was originally ok, this approach is not consistent with the current approach used in modtimedep

Proposed solution for modtimedepsv :

1. make kflux and kls variables consistent with modtimedep:
   l.45-46

  integer    :: kflux
  integer    :: kls

2. continue consistency by linking with modtestbed in inittimedepsv
   l.60 in:

    use modtestbed,        only : ltestbed,ntnudge,&
                                  tb_time

l.70 in:

    if (ltestbed) then
      kflux = ntnudge
      kls   = ntnudge
    else
      kflux = 10000
      kls   = 10000
    end if

3. remove incorrect MPI command

l.152 delete:

 call MPI_BCAST(timesvz(1:kflux),kflux,MY_REAL,0,comm3d,mpierr)

[fjansson]

Hi @jchylik , thanks for reporting this. I committed your proposed changes to the branch to4.3_Fredrik . Could you please test this version?

Also otherwise, we're preparing to release version 4.3, so testing of the prerelease version on your own cases would be most welcome (branch to4.3, to4.3_Fredrik is currently the same with only this fix added).

[jchylik]

Thank you @fjansson , I will check it soon.

Speaking about test cases for 4.3, I am afraid we cannot send many cases, as most of them are optimised for full 3-phase microphysics.