-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range component ticks fix #438
Merged
benjitrosch
merged 6 commits into
daisyui:main
from
itaiperi:bugfix/range-component-steps-and-ticks
Jan 1, 2024
Merged
Range component ticks fix #438
benjitrosch
merged 6 commits into
daisyui:main
from
itaiperi:bugfix/range-component-steps-and-ticks
Jan 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for react-daisyui processing.
|
Also, removed usage of |
benjitrosch
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix @itaiperi!
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #437.
In a nutshell:
Range
component ticks math is wrong, only takes into account range [0, 100] and no step sizes < 1. Also, ticks are always displayed whenstep
is provided, whether you want to or not.displayTicks
andticksStep
parameters to control when to display ticks, and what the ticks step size should be, which can now be different thanstep
(before, they were the same by design). Also, take into accountprops.min
andprops.max
to allow for the range the user intended in the ticks.