Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular Dependency in ChatBubbleAvatar #329

Closed
dev0T opened this issue Apr 5, 2023 · 1 comment
Closed

Circular Dependency in ChatBubbleAvatar #329

dev0T opened this issue Apr 5, 2023 · 1 comment

Comments

@dev0T
Copy link
Contributor

dev0T commented Apr 5, 2023

While getting familiar with the library codebase I realized a message regarding a Circular Dependency when running npm run dist:

Circular dependency: src/index.ts -> src/ChatBubble/index.ts -> src/ChatBubble/ChatBubble.tsx -> src/ChatBubble/ChatBubbleAvatar.tsx -> src/index.ts

This is caused by the ChatBubbleAvatar importing Avatar from src/index.ts instead of src/Avatar.

The current import looks like this:

import { Avatar, AvatarProps } from '..'

When they should be:

import Avatar, { AvatarProps } from '../Avatar'

I am making a PR to fix it right now.

@benjitrosch
Copy link
Collaborator

Thanks for finding this, approved the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants