-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Tooltip positions #235
Conversation
Replaced the string interpolation so that tailwind can capture the classnames correctly
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @Pr0dt0s, thank you for the PR. I've tested your fix locally and it works. But I don't know if this is the fix for us. Can you test/confirm this? |
Like @Klaas058 said, if updating |
I don't know what I did in my testing to get a false positive but upgrading This solution looks acceptable for now. |
Hey @Klaas058, yeah I coudn´t understand how updating a run time library would affect tailwind´s compile time process. And I still dont know why other interpolations work, like Note. Not all of the other class string interpolations work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for now so we can release a fix, but hopefully we can revisit string interpolation in the future. Thanks for finding this @Pr0dt0s!
Replaced the string interpolation so that tailwind can capture the classnames correctly, fixes #234