Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Tabs state externally #226

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

chargome
Copy link
Contributor

@chargome chargome commented Oct 5, 2022

  • Tabs state is now controlled externally by passing value and onChange props to the <Tabs> component.
  • added tests for <Tabs /> component (Create Tests for components #137)

resolves #220

@netlify
Copy link

netlify bot commented Oct 5, 2022

👷 Deploy Preview for react-daisyui processing.

Name Link
🔨 Latest commit c612d95
🔍 Latest deploy log https://app.netlify.com/sites/react-daisyui/deploys/633dc1557c78360008ae77f8

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for react-daisyui ready!

Name Link
🔨 Latest commit c612d95
🔍 Latest deploy log https://app.netlify.com/sites/react-daisyui/deploys/633dc1557c78360008ae77f8
😎 Deploy Preview https://deploy-preview-226--react-daisyui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 5, 2022

👷 Deploy Preview for react-daisyui processing.

Name Link
🔨 Latest commit c612d95
🔍 Latest deploy log https://app.netlify.com/sites/react-daisyui/deploys/633dc1557c78360008ae77f8

Copy link
Collaborator

@benjitrosch benjitrosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and thanks for including tests as well!

@benjitrosch benjitrosch merged commit e0eb9c0 into daisyui:main Oct 6, 2022
This was referenced Oct 6, 2022
This was referenced Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove state from Tabs component
2 participants