Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor alert to allow customization #173 #175

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix: refactor alert to allow customization #173 #175

merged 1 commit into from
Jul 19, 2022

Conversation

christianblandford
Copy link
Member

Closes #173

  • Allows passing in/rendering children inside of an alert
  • Removed label tag containing children
  • Added innerClassName prop to allow customizing the container inside of the alert
  • Added story showing example of a custom alert

@netlify
Copy link

netlify bot commented Jul 19, 2022 •
edited
Loading

✅ Deploy Preview for react-daisyui ready!

Name Link
🔨 Latest commit b8b071a
🔍 Latest deploy log https://app.netlify.com/sites/react-daisyui/deploys/62d738e9ac05d2000942e6fd
😎 Deploy Preview https://deploy-preview-175--react-daisyui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benjitrosch benjitrosch merged commit 9f990b7 into main Jul 19, 2022
@benjitrosch benjitrosch deleted the christian/alert-label-fix branch July 19, 2022 23:33
This was referenced Jul 19, 2022
Merged
Closed
@github-actions github-actions bot mentioned this pull request Aug 8, 2022
Closed
This was referenced Aug 16, 2022
Closed
Closed
This was referenced Sep 5, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Closed
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Closed
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
This was referenced Oct 31, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Dec 12, 2022
Closed
This was referenced Dec 30, 2022
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Closed
This was referenced Apr 4, 2023
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Closed
This was referenced Jul 28, 2023
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Closed
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Closed
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
Closed
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjitrosch benjitrosch benjitrosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert component has children within a label element
2 participants
@christianblandford @benjitrosch