Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Remain Unsaved #114

Open
kevin-induro opened this issue Feb 12, 2025 · 0 comments
Open

Files Remain Unsaved #114

kevin-induro opened this issue Feb 12, 2025 · 0 comments

Comments

@kevin-induro
Copy link

Describe the bug
When I save a file, the file remains unsaved in the VS Code UI.

To Reproduce
Click Ctrl-S on a file.

Expound
I can't tell whether this is a bug with this extension, the Format Code Action extension, the Prettier extension, or VS Code itself. From what I can tell, because of the settings of the Format Code Extension, Prettier formats the file, ESLint fixes anything, then this extension runs. If I remove this extension from the codeActionsOnSave list (see settings below), then I have no issue, but my imports are not formatted correctly. Furthermore, if I remove everything except this extension from the list, I still have the issue. Thus I believe the issue lies with some change in VS Code that has caused this extension to no longer perform correctly and this extension needs to be updated.

OS (please complete the following information):

  • OS: Windows
  • Version: 11

VS Code (please complete the following information):

  • Version: 1.95 and on. This did not happen in 1.94 and below

VS Code Settings

{
	"prettier.printWidth": 120,
	"prettier.singleQuote": true,
	"prettier.endOfLine": "auto",
	"prettier.useTabs": true,
	"[typescript]": {
		"editor.defaultFormatter": "esbenp.prettier-vscode"
	},
	"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
	"tsImportSorter.configuration.maxLineLength": 120,
	"tsImportSorter.configuration.wrappingStyle": {
		"maxLineLength": 120,
		"maxBindingNamesPerLine": 0,
		"maxNamesPerWrappedLine": 0
	},
	"editor.codeActionsOnSave": {
		"angular-formatter.format": "always",
		"source.formatDocument": "always",
		"source.fixAll.eslint": "always",
		"source.organizeImports.sortImports": "always"
	},
}

.prettierrc/.prettierrc.js/prettier.config.js/.prettierrc.toml (if any)
filename: .prettierrc

{
  "arrowParens": "always",
  "bracketSpacing": true,
  "endOfLine": "lf",
  "printWidth" : 120,
  "semi": true,
  "singleQuote": true,
  "tabWidth": 2,
  "useTabs": false
}

Installed VS Code extensions

dbaeumer.vscode-eslint
dozerg.tsimportsorter
esbenp.prettier-vscode
redhat.vscode-yaml
rohit-gohri.format-code-action
vscode-icons-team.vscode-icons
waderyan.gitblame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant