Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example with cssmodules and pages router #641

Merged
merged 6 commits into from
Apr 6, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 31, 2024

  • added 04_cssmodules example
  • removed 09_cssmodules example
  • changed 12_css example to include layout in 09_cssmodules

Remaining:

  • Flash of unstyled content (FOUC) in DEV
  • No styles in client components in PRD

Copy link

vercel bot commented Mar 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 6, 2024 3:17am

Copy link

codesandbox-ci bot commented Mar 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 31, 2024

Remaining:

  • Flash of unstyled content (FOUC) in DEV
  • No styles in client components in PRD

@Aslemammad I need your help.

dai-shi added a commit that referenced this pull request Apr 4, 2024
I had thought it would be nice to have a single `--example` option, but
changed my mind. This introduces `--choose` option again.


#315 (reply in thread)

closes #625
along with #641
@dai-shi
Copy link
Owner Author

dai-shi commented Apr 6, 2024

Merging this and open a new issue for remaining tasks.

@dai-shi dai-shi merged commit 6359a0b into main Apr 6, 2024
28 checks passed
@dai-shi dai-shi deleted the pages-example-cssmodule branch April 6, 2024 03:29
@dai-shi
Copy link
Owner Author

dai-shi commented Apr 6, 2024

Remaining:

  • Flash of unstyled content (FOUC) in DEV
  • No styles in client components in PRD

@Aslemammad I need your help.

#651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant