fix: do not SSR index page #573
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
himself65
force-pushed
the
himself65/fix-dynamic-page
branch
from
cdbf145 to
53bad46
Compare
| if (isStatic) { | ||
| const moduleIds = await unstable_collectClientModules(input); | ||
| path2moduleIds[pathname] = moduleIds; | ||
| } |
There was a problem hiding this comment.
Hmm, I think we want to use path2moduleIds for dynamic pages too (even though, it's suboptimal).
If unstable_collectClientModules is only the place of the problem, it doesn't actually leak the information because it's thrown away.
That said, I wish there would be an alternative way to collect client modules without running the code. Can we statically analyze the code?
There was a problem hiding this comment.
Oh, yes we can. I read the React-server source code, we could collect client info during vite build
There was a problem hiding this comment.
my current idea is to add a hook on the resolve module function and give id -> moduleId[] Map in the analysis plugin
There was a problem hiding this comment.
that sounds nice. we may need some research, so this would come at v0.21 or later.
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
|
Let's start it over. |
Fixes: #543