Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build Dagu on a freshly cloned repo #514

Closed
rafiramadhana opened this issue Jan 1, 2024 · 2 comments · Fixed by #519
Closed

Failed to build Dagu on a freshly cloned repo #514

rafiramadhana opened this issue Jan 1, 2024 · 2 comments · Fixed by #519
Labels
bug Something isn't working

Comments

@rafiramadhana
Copy link
Contributor

rafiramadhana commented Jan 1, 2024

How to reproduce

  1. Clone dagu
  2. Run make build

When running make build, I ran into this issue (I omit some part of the logs for brevity)

➜  dagu git:(main) make build
yarn install v1.22.21
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...

...

rm: cannot remove './service/frontend/assets/*.js': No such file or directory
make: *** [Makefile:72: build-ui] Error 1

To solve this, I think we can update the Makefile target build-ui by doing rm -f

build-ui:
	@cd ui; \
		yarn && yarn build

	@rm -f ./service/frontend/assets/*.js
	@rm -f ./service/frontend/assets/*.woff
	@rm -f ./service/frontend/assets/*.woff2

	@cp ui/dist/*.js ./service/frontend/assets/
	@cp ui/dist/*.woff ./service/frontend/assets/
	@cp ui/dist/*.woff2 ./service/frontend/assets/

https://github.com/dagu-dev/dagu/blob/main/Makefile#L70C1-L80C48

Thx!

@rafiramadhana rafiramadhana changed the title Failed make build on a freshly cloned repo Failed to build Dagu on a freshly cloned repo Jan 1, 2024
@yottahmd
Copy link
Collaborator

yottahmd commented Jan 1, 2024

Hi, thanks a lot for submitting the Issue. I completely agree, let's update the Makefile.

@rafiramadhana
Copy link
Contributor Author

let's update the Makefile.

Ok, I will submit a PR

@yottahmd yottahmd added the bug Something isn't working label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants