Fix linter errors #556
Merged
Fix linter errors #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors instead: 'fmt.Errorf()'"
…of var something; it is the zero value (revive)"
…k resources. Use time.NewTimer instead.\"
…nabled 25) (revive)
…lified to if !c { ... return } ... (move short variable declaration to its own line if necessary) (revive)"
…verRequestedShutdown", use "!errors.Is(err, sock.ErrServerRequestedShutdown)" instead (goerr113)"
…lified to if !c { ... return } ... (revive)"
Kiyo510
changed the title
goimports-ed (goimports)"
|
For some reason the test seems to be failing, I will check tomorrow! 🙏 |
…d of "!=" operator (revive)"
Kiyo510
force-pushed
the
fix-linter-errors
branch
2 times, most recently
from
7bc6fb8 to
d37bcf4
Compare
|
Hi,@yohamta. During the implementation I noticed that there was a problem with the data race, so I created an issue. Please check it out. |
yottahmd
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Please See commit log
deep-exit: calls to log.Fatal only in main() or init() functions (revive)some function has cyclomatic complexity 39 (> max enabled 25) (revive)ref: before fix lint errors
Thank you for your confirmation!
Related issue
Fixes #553 .