Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding refreshThreshold Parameter to the wrap Function #606

Closed
eternasuno opened this issue Oct 27, 2023 · 3 comments · May be fixed by dagistan-tuncbilek/pos-api#3
Closed

Adding refreshThreshold Parameter to the wrap Function #606

eternasuno opened this issue Oct 27, 2023 · 3 comments · May be fixed by dagistan-tuncbilek/pos-api#3
Labels
enhancement

Comments

@eternasuno
Copy link

The cache's TTL can vary significantly, for instance, between 5 minutes and 1 day. It's challenging to determine a single, unified refreshThreshold setting for all use cases. Therefore, adding a separate refreshThreshold parameter to the wrap function could be a valuable enhancement.
@jaredwray
Copy link
Owner

@eternasuno - can you give a couple examples of this use case?

@eternasuno
Copy link
Author

@eternasuno - can you give a couple examples of this use case?

For example, I cached an authentication token, which expires after 2 hours. Therefore, the refreshThreshold should be set to 0. On the one hand, I have some caches that need to update their expiration time, but they cannot do so when there is only a unified refreshThreshold.

lchenay added a commit to lchenay/node-cache-manager that referenced this issue Dec 29, 2023
@lchenay
Add refreshThreshold as parameter of wrap function. Fix jaredwray#606
999e828
@lchenay
Copy link
Contributor

lchenay commented Dec 29, 2023

+1 for this feature.

I have created a little WIP PR: #630

I think the need of refreshThreshold parameter is linked to what is the right usage of cache-manager.
If you have only 1 instance of cache, then finding global refreshThreshold value is hard. Some people may create 1 instance per type of cache ; and so using hard coded as default value ttl / refreshThreshold are not an issue in this case.

@dagistan-tuncbilek dagistan-tuncbilek mentioned this issue Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade cache-manager from 5.2.4 to 5.5.3 dagistan-tuncbilek/pos-api
3 participants
@lchenay @jaredwray @eternasuno