fix: Validation of a self-signed certificate does not require its presence in the system wide trust store any more #830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Not really, but many complains and people wondering, why it is the case
Checklist
Description
With that update, you can use self-signed certificates (highly discouraged for production), respectively the corresponding keys to e.g. sign the JWTs issued by heimdall without the need to make the self-signed certificate present in the system-wide trust store.
Before the change introduced with this PR, heimdall would log
x509: certificate signed by unknown authority
and refuse starting.