fix: Working authClassName
filter if multiple heimdall deployments are present in a cluster
#742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #736
Checklist
Description
This PR fixes the issue mentioned above by moving the filtering logic into the creation, update and deletion functions.
It does make the code less DRY, but I've never written Go before so I'm unsure how to solve this more cleanly.
It furthermore also solves an issue where rewrites have to have all fields set, which is incorrect behavior.
It also contains fixes to make the DNS resolution tests pass more reliably
Changelist
fix: Fix authClassName filtering
fix: Make DNS resolution tests pass more reliably
fix: Allow rewrites with only a subset of fields set