Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for automatically Helm roll deployments #731

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jun 28, 2023

Related issue(s)

closes #701

Checklist

Description

Adds an annotation as described in https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

This should automatically ensure a zero-downtime restart of the heimdall pods should the values and by extension the ConfigMap be updated via helm upgrade.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #731 (572c261) into main (d277887) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   89.49%   89.59%   +0.10%     
==========================================
  Files         213      215       +2     
  Lines        9112     9229     +117     
==========================================
+ Hits         8155     8269     +114     
- Misses        765      767       +2     
- Partials      192      193       +1     

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit bd2d438 into main Jun 28, 2023
@dadrus dadrus deleted the feat/helm_auto_redeploy branch June 28, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically roll Helm deployments on config change
1 participant