Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configuration of basic_auth authenticator fixed #556

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Apr 13, 2023

Related issue(s)

None

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.

Description

The schema configuration for the basic_auth authenticator was not inline with the documentation and the implementation. Instead of the property user_id it has client_id defined, which is neither defined by the RFC 7617, nor implemented and documented this way. So basically, the usage of the basic_auth authenticator is impossible until this PR

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #556 (b937b09) into main (dba0a87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         207      207           
  Lines        8809     8809           
=======================================
  Hits         7815     7815           
  Misses        804      804           
  Partials      190      190           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit 8eb5f65 into main Apr 13, 2023
@dadrus dadrus deleted the fix/basic_auth branch April 13, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant