Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jwt finalizer extended to support templating via values property #2193

Merged
merged 12 commits into from
Feb 18, 2025

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Feb 18, 2025

Related issue(s)

closes #2137

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.
  • I have updated the documentation.

Description

This PR implements the idea described in the referenced FR.

@dadrus dadrus changed the title Feat/values in finalizers feat: jwt finalizer extended to support templating via values property Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (2b4e1c0) to head (3849481).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
+ Coverage   90.46%   90.49%   +0.02%     
==========================================
  Files         279      279              
  Lines       12230    12247      +17     
==========================================
+ Hits        11064    11083      +19     
+ Misses        921      919       -2     
  Partials      245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit bf833c4 into main Feb 18, 2025
28 checks passed
@dadrus dadrus deleted the feat/values_in_finalizers branch February 18, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant