feat!: Usage of trusted_proxies is mandatory for Decision API to accept X-Forwarded-* headers
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadrus
changed the title
trusted_proxies mandatory to accept X-Forwarded-* headerstrusted_proxies is mandatory to accept X-Forwarded-* headers
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 85.55% 85.50% -0.06%
==========================================
Files 146 146
Lines 5449 5449
==========================================
- Hits 4662 4659 -3
- Misses 668 670 +2
- Partials 119 120 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
dadrus
changed the title
trusted_proxies is mandatory to accept X-Forwarded-* headerstrusted_proxies is mandatory for Decision API to accept X-Forwarded-* headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95
This is already the default behavior for the proxy mode. With this PR it is also true for the decision operation mode