Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept header usage #1107

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix: Accept header usage #1107

merged 2 commits into from
Dec 20, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Dec 20, 2023

Related issue(s)

Not documented. Encountered during the review of #1043

Checklist

Description

In many places, heimdall implements useful defaults. Among other things, these are HTTP headers. On of such defaults is the Accept header, which has unfortunately been set as Accept-Type, which just does not exist. In principle, there should not be any issues because of this, as many implementations are just ignoring such headers, especially in m2m contexts.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2beb9b0) 89.20% compared to head (8f9e5d5) 89.20%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         246      246           
  Lines       10367    10367           
=======================================
  Hits         9248     9248           
  Misses        881      881           
  Partials      238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit f738ee8 into main Dec 20, 2023
27 checks passed
@dadrus dadrus deleted the fix/accept_header_usage branch December 20, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant