Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Request.ClientIP renamed to Request.ClientIPAddresses to reflect the actual contents #1066

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Nov 24, 2023

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.
  • I have updated the documentation.

Description

The type of Request.ClientIP property was always an array of strings. Unfortunately, the name ClientIP does not reflect this and is misleading. This PR resolves this by renaming this property to ClientIPAddresses.


BEGIN_COMMIT_OVERRIDE
refactor!: Request.ClientIP renamed to Request.ClientIPAddresses to reflect the actual contents (#1066)
END_COMMIT_OVERRIDE

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (943c9ce) 89.57% compared to head (bee9d41) 89.57%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         248      248           
  Lines       10221    10221           
=======================================
  Hits         9155     9155           
  Misses        833      833           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit 0f9484f into main Nov 24, 2023
26 checks passed
@dadrus dadrus deleted the refactor/request_client_ip_rename branch November 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant