Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more regression #456

Closed
yallie opened this issue Feb 11, 2022 · 2 comments
Closed

One more regression #456

yallie opened this issue Feb 11, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yallie
Copy link
Contributor

yallie commented Feb 11, 2022

Hello Maksim,

Looks like I've found one more regression, sorry...
Breaking change was introduced in the recent commit 5946550, ~5 commits ago.
It seems to be related to some combination of singletons and lazy wrappers.
But I haven't prepared an isolated unit test yet.
I'll update the title when I find what exactly was broken.

@dadhi
Copy link
Owner

dadhi commented Feb 11, 2022

@yallie I am still working on it in the scope of #435

It is a real PITA. This one is preventing me to conclude the release of the next bug-fix version.
Up to now I have tried 3 or 4 approaches - and have another one in mind.
Will be doing Today or on the weekend.

@yallie
Copy link
Contributor Author

yallie commented Feb 26, 2022

I couldn't reproduce the issue as an isolated unit test, but now I see that it's fixed in the latest commit.
I guess I can close this issue.

@yallie yallie closed this as completed Feb 26, 2022
@dadhi dadhi self-assigned this Feb 27, 2022
@dadhi dadhi added this to the v4.8.7 milestone Feb 27, 2022
@dadhi dadhi added the bug Something isn't working label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants