-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md #5
Comments
TODO
|
public class GithubIssueRepositoryStepIdManagementAspect { // TODO : ํ ์คํธ ์ฝ๋ ์์ฑ ์ฐธ๊ณ https://chatgpt.com/c/f5048ee1-e629-454d-927d-ffaccad6e537 |
Description:
The dependencies of some of the beans in the application context form a cycle:
localMethodExecutionTimeLoggingAspect defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/aop/LocalMethodExecutionTimeLoggingAspect.class]
โ
discordNotificationService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/notification/DiscordNotificationService.class]
โ
restTemplateHttpClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/RestTemplateHttpClient.class]
โโโโโโโ
| appConfig defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/config/AppConfig.class]
โ โ
| gitHubApiLoggingInterceptor defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/interceptor/GitHubApiLoggingInterceptor.class]
โ โ
| logDirectSaveGoogleSheetsService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/log/LogDirectSaveGoogleSheetsService.class]
โ โ
| logGoogleSheetsRepository defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/repository/log/LogGoogleSheetsRepository.class]
โ โ
| googleSheetsClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/googlesheets/GoogleSheetsClient.class]
โโโโโโโ
Action:
Relying upon circular references is discouraged and they are prohibited by default. Update your application to remove the dependency cycle between beans. As a last resort, it may be possible to break the cycle automatically by setting spring.main.allow-circular-references to true.
Description:
The dependencies of some of the beans in the application context form a cycle:
localMethodExecutionTimeLoggingAspect defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/aop/LocalMethodExecutionTimeLoggingAspect.class]
โ
discordNotificationService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/notification/DiscordNotificationService.class]
โ
discordRestTemplateHttpClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/DiscordRestTemplateHttpClient.class]
โโโโโโโ
| appConfig defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/config/AppConfig.class]
โ โ
| gitHubApiLoggingInterceptor defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/interceptor/GitHubApiLoggingInterceptor.class]
โ โ
| logDirectSaveGoogleSheetsService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/log/LogDirectSaveGoogleSheetsService.class]
โ โ
| logGoogleSheetsRepository defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/repository/log/LogGoogleSheetsRepository.class]
โ โ
| googleSheetsClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/googlesheets/GoogleSheetsClient.class]
โโโโโโโ
Action:
Relying upon circular references is discouraged and they are prohibited by default. Update your application to remove the dependency cycle between beans. As a last resort, it may be possible to break the cycle automatically by setting spring.main.allow-circular-references to true.
|
1๋ฒ์งธ ์ํ ์ฐธ์กฐ ๋ฌธ์ Description:
The dependencies of some of the beans in the application context form a cycle:
localMethodExecutionTimeLoggingAspect defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/aop/LocalMethodExecutionTimeLoggingAspect.class]
โ
discordNotificationService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/notification/DiscordNotificationService.class]
โ
restTemplateHttpClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/RestTemplateHttpClient.class]
โโโโโโโ
| appConfig defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/config/AppConfig.class]
โ โ
| gitHubApiLoggingInterceptor defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/interceptor/GitHubApiLoggingInterceptor.class]
โ โ
| logDirectSaveGoogleSheetsService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/log/LogDirectSaveGoogleSheetsService.class]
โ โ
| logGoogleSheetsRepository defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/repository/log/LogGoogleSheetsRepository.class]
โ โ
| googleSheetsClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/googlesheets/GoogleSheetsClient.class]
โโโโโโโ
Action:
Relying upon circular references is discouraged and they are prohibited by default. Update your application to remove the dependency cycle between beans. As a last resort, it may be possible to break the cycle automatically by setting spring.main.allow-circular-references to true.
Process finished with exit code 1
ํด๊ฒฐ ๋ฐฉ๋ฒ
|
2๋ฒ์งธ ์ํ ์ฐธ์กฐ ๋ฌธ์ Description:
The dependencies of some of the beans in the application context form a cycle:
localMethodExecutionTimeLoggingAspect defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/aop/LocalMethodExecutionTimeLoggingAspect.class]
โโโโโโโ
| discordNotificationService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/notification/DiscordNotificationService.class]
โ โ
| restTemplateHttpClient defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/RestTemplateHttpClient.class]
โ โ
| appConfig defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/common/config/AppConfig.class]
โ โ
| gitHubApiLoggingInterceptor defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/infrastructure/resttemplate/interceptor/GitHubApiLoggingInterceptor.class]
โ โ
| logDirectSaveGoogleSheetsService defined in file [/Users/daheekwak/Desktop/review-study-app/out/production/classes/com/example/review_study_app/service/log/LogDirectSaveGoogleSheetsService.class]
โโโโโโโ
Action:
Relying upon circular references is discouraged and they are prohibited by default. Update your application to remove the dependency cycle between beans. As a last resort, it may be possible to break the cycle automatically by setting spring.main.allow-circular-references to true.
Process finished with exit code 1
ํด๊ฒฐ ๋ฐฉ๋ฒ
|
๋์ค์ฝ๋ 400 Bad Request ์๋ฌ ํด๊ฒฐ
|
@Async.mov |
2024-08-22.6.51.00.mov |
As-Is : ๋๊ธฐ ๋ฐฉ์๊ธฐ์กด ๋ฐฉ์์ ๋น์ฆ๋์ค ๋ก์ง์ธ Github ๋ก์ง๊ณผ ๋ถ๊ฐ ๊ธฐ๋ฅ ๋ก์ง์ธ Google Sheets Logging ๋ก์ง์ด ๋๊ธฐ ๋ฐฉ์์ผ๋ก ์ํ๋์์ต๋๋ค.
To-Be : ๋น๋๊ธฐ ๋ฐฉ์@async๋ก ๋น์ฆ๋์ค ๋ก์ง์ธ Github ๋ก์ง๊ณผ ๋ถ๊ฐ ๊ธฐ๋ฅ ๋ก์ง์ธ Google Sheets Logging ๋ก์ง์ ๋์ปคํ๋งํ์ฌ ๋ค์๊ณผ ๊ฐ์ ์ฑ๊ณผ๋ฅผ ์ป์์ต๋๋ค.
|
๋น๋๊ธฐ๋ก ๋น์ฆ๋์ค ๋ก์ง๊ณผ ๋ถ๊ฐ ๊ธฐ๋ฅ ๋ก์ง์ ๋์ปคํ๋ง์์ผ ์ฅ์ ๊ฒฉ๋ฆฌ๋ฅผ ํตํด ์๋ฒ์ ์์ ์ฑ ํฅ์๊ณผ ์ฑ๋ฅ ํฅ์๊ฐ์ ์ 1. ๋๊ธฐ -> ๋น๋๊ธฐ๋ก ์ฅ์ ์ ํ ๋ฌธ์ ํด๊ฒฐ๊ฐ์ ์ 2. ๋น๋๊ธฐ+์ฑ๊ธ ์ค๋ ๋๋ก ์ํ ์๊ฐ ์ง์ฐ ๋ฌธ์ ํด๊ฒฐ(๋จ, ๋ฉํฐ์ค๋ ๋๊ฐ ์๋ ์ฑ๊ธ ์ค๋ ๋ ์ํฉ์์์ ์ฑ๋ฅ์) ์ฑ๊ธ ์ค๋ ๋๋ฐฉ์์ผ๋ก ๋์์ฑ ๋ฌธ์ ํด๊ฒฐ๊ฐ์ ์ 1. ๋ฉํฐ ์ค๋ ๋ -> ์ฑ๊ธ ์ค๋ ๋๋ก ๋์์ฑ ๋ฌธ์ ํด๊ฒฐ๋๊ธฐ -> ๋น๋๊ธฐ : ์ฅ์ ์ ํ ๋ฌธ์ ํด๊ฒฐ |
๐โโ๏ธ ์๊ฐ
๐์ฃผ์ ๊ธฐ๋ฅ
1. โฐ ์ค์ผ์ค๋ฌ ๊ธฐ๋ฅ
2. ๐ ์๋ฆผ ๊ธฐ๋ฅ
3. ๐ ๋ก๊น ๊ธฐ๋ฅ
๐๏ธ ๊ธฐ๊ฐ
๐ ๏ธ ๊ธฐ์
๐ ์ฃผ์ ์ฑ๊ณผ ๋๋ ๋ฌธ์ ํด๊ฒฐ/๊ฐ์ ์ฌ๋ก
1. ๋น๋๊ธฐ ๋ฐ ์ฑ๊ธ ์ค๋ ๋๋ฅผ ํ์ฉํ์ฌ ๋น์ฆ๋์ค ๋ก์ง๊ณผ ๋ถ๊ฐ ๊ธฐ๋ฅ ๋ก์ง ์ต์ ํ(์ฅ์ ์ ํ ๋ฌธ์ ํด๊ฒฐ, ๋์์ฑ ๋ฌธ์ ํด๊ฒฐ ๋ฐ ์ฑ๋ฅ ์ต์ ํ)(๊ด๋ จ ๋งํฌ)
2. ์๋ฆผ ๋ฉ์์ง ์ ์ก ๋ฐฉ์ ๋ฐ ์๋ฆผ ์ ์ก ์ฃผ๊ธฐ ๋ณ๊ฒฝ์ผ๋ก ๋์ค์ฝ๋ ์๋ฆผ ๊ธฐ๋ฅ ๊ฐ์
๊ฐ์ ์ 2-1. ๋ฐ์ดํฐ ์ ์ก ๋ฐฉ์ ๋ณ๊ฒฝ(ํ ์คํธ ๊ธฐ๋ฐ ๋ฐฉ์ -> ํ์ผ ์ฒจ๋ถ ๋ฐฉ์)์ผ๋ก ์ต๋ ๊ธ์์ ์ด๊ณผ ๋ฌธ์ ํด๊ฒฐ (๊ด๋ จ ๋งํฌ)
๊ฐ์ ์ 2-2. ๋ฐ์ดํฐ ์ ์ก ์ฃผ๊ธฐ ๋ณ๊ฒฝ(๋ชจ๋ ๋ฐ์ดํฐ ์ ์ฅ์๋ง๋ค -> ํ๋ฒ์ ๋ฐฐ์น๋ก)์ผ๋ก DX ํฅ์(๊ด๋ จ ๋งํฌ)
3. ๊ธฐํ ๊ฐ์ ์ ๋ค (์ด n๊ฐ)
(1) SRP ์์น์ ํ์ฉํ์ฌ ์ํ ์ฐธ์กฐ ๋ฌธ์ ํด๊ฒฐ(๊ด๋ จ ๋งํฌ)
(2) ๊ตฌ๊ธ ์ํธ ๊ฐ์ฒด๋ฅผ Bean ๋ฑ๋ก ํ์ฌ ~ ๊ฐ์
(3) AOP ํ์ฉํ์ฌ 00 ํฅ์
(4) AOP ๋์ Interceptor ํ์ฉํ์ฌ HTTP ์์ฒญ/์๋ต ๋ก๊น ๊ธฐ๋ฅ ๊ตฌํ
(5) ๊ตฌ๊ธ ์ํธ ๊ฐ์ฒด ์์ฑ์ ๋ค์ํ ์์ธ์ ์ํด ๊ฐ์ฒด ์์ฑ์ด ์คํจํ ์ ์์ด์, CreateSheetsFailReason์ด๋ผ๋ enum ํด๋์ค๋ฅผ ํ๋ ๋ง๋ค์ด์ ์์ธ ์ํฉ์ ์นดํ ๊ณ ๋ฆฌํ ํ์ฌ, ๋๋ฒ๊น ์ ๋ฌธ์ ์ ์์ธ์ ๋ช ํํ ๊ตฌ๋ถํ ์ ์๊ฒ ํ์์ต๋๋ค.
๐ ์ฃผ์ ํด๋์ค ๊ตฌ์กฐ(?) (๋งํฌ)
The text was updated successfully, but these errors were encountered: