New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A more convenient way of computing height? #31

Closed

mbostock opened this issue Apr 1, 2016 · 0 comments

Assignees

Member

mbostock commented Apr 1, 2016

This is a little difficult to remember:

root.eachBefore(function(d) {
  var h = 0;
  do d.height = h;
  while ((d = d.parent) && (d.height < ++h));
});

We could compute it by default, as we do for depth. Or perhaps have a node.computeHeight() method.

mbostock self-assigned this

mbostock closed this as completed in

8b4c396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment