From 6b7c7c32501f758fd095126903d46b1e743811f3 Mon Sep 17 00:00:00 2001 From: clydin Date: Mon, 15 May 2017 17:46:05 -0400 Subject: [PATCH] fix(@angular/cli): enable full node module resolution for project deps (#6276) --- .../@angular/cli/models/webpack-configs/common.ts | 2 +- tests/e2e/tests/misc/module-resolution.ts | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 tests/e2e/tests/misc/module-resolution.ts diff --git a/packages/@angular/cli/models/webpack-configs/common.ts b/packages/@angular/cli/models/webpack-configs/common.ts index bec60dda00a3..1b1d7c0d881d 100644 --- a/packages/@angular/cli/models/webpack-configs/common.ts +++ b/packages/@angular/cli/models/webpack-configs/common.ts @@ -67,7 +67,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) { devtool: buildOptions.sourcemaps ? 'source-map' : false, resolve: { extensions: ['.ts', '.js'], - modules: [nodeModules], + modules: ['node_modules', nodeModules], }, resolveLoader: { modules: [nodeModules] diff --git a/tests/e2e/tests/misc/module-resolution.ts b/tests/e2e/tests/misc/module-resolution.ts new file mode 100644 index 000000000000..6b02d7d4e1cb --- /dev/null +++ b/tests/e2e/tests/misc/module-resolution.ts @@ -0,0 +1,13 @@ +import { appendToFile, prependToFile } from '../../utils/fs'; +import { ng, silentNpm } from '../../utils/process'; + + +export default async function () { + await silentNpm('install', 'firebase@3.7.8'); + + await prependToFile('src/app/app.module.ts', 'import * as firebase from \'firebase\';'); + await appendToFile('src/app/app.module.ts', 'firebase.initializeApp({});'); + + await ng('build'); + await ng('build', '--aot'); +}