Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listening events via addEventsListener #113

Open
OlegAndreych opened this issue May 18, 2017 · 0 comments
Open

Listening events via addEventsListener #113

OlegAndreych opened this issue May 18, 2017 · 0 comments

Comments

@OlegAndreych
Copy link

Looking through the code I've stumbled upon constructs like:

// when tab is above to close
window.onbeforeunload = function() {
     jsflight.stopTimers();

MDN states, that such events should be processed via addEventsListener method rather than function assignment.
@gallyamb gallyamb mentioned this issue Jul 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OlegAndreych