Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some files and content from the repo that are not necessary for our use case #74

Closed
wants to merge 2 commits into from

Conversation

jennifer-shehane
Copy link
Member

PR Description

Just removing some noise from the repo - where these extra files aren't needed.

@jennifer-shehane jennifer-shehane self-assigned this Sep 10, 2024
"engines": {
"node": ">= 6"
"node": ">= 18"
Copy link

@MikeMcC399 MikeMcC399 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change which would stop Cypress being installed in a Node.js 16 environment. By default npm warns and Yarn aborts if the engines parameter requirements are not met. This issue is marked as a breaking change.

It would need the version of @cypress/request bumping to 4.0.0

Even if you relaxed the condition to "node": ">= 16", it would still be a breaking change and need a major version update.

@MikeMcC399
Copy link

@jennifer-shehane

Deleting the LICENSE file seems to go against the licensing provisions of the repo https://github.com/request/request from which this repo is forked.

  1. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or > without modifications, and in Source or Object form, provided that You meet the following conditions:

You must give any other recipients of the Work or Derivative Works a copy of this License; and
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants