fix: allow assignment of children of whitelisted commands in no-assig…

…ning-return-values rule (#60)
cypress-io · May 27, 2020 · 2d127d0 · 2d127d0
1 parent bcc04a6
commit 2d127d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/rules/no-assigning-return-values.js b/lib/rules/no-assigning-return-values.js
@@ -59,7 +59,9 @@ function isCypressCommandDeclaration (declarator) {
 
   const commandName = get(declarator, 'init.callee.property.name')
 
-  if (commandName && whitelistedCommands[commandName]) return
+  const parent = get(object, 'parent.property.name') || get(declarator, 'id.name')
+
+  if (commandName && (whitelistedCommands[commandName] || whitelistedCommands[parent])) return
 
   return object.name === 'cy'
 }
diff --git a/tests/lib/rules/no-assigning-return-values.js b/tests/lib/rules/no-assigning-return-values.js
@@ -16,6 +16,7 @@ ruleTester.run('no-assigning-return-values', rule, {
     { code: 'const foo = bar();', parserOptions },
     { code: 'const foo = bar().baz();', parserOptions },
     { code: 'const spy = cy.spy();', parserOptions },
+    { code: 'const spy = cy.spy().as();', parserOptions },
     { code: 'const stub = cy.stub();', parserOptions },
     { code: 'const result = cy.now();', parserOptions },
     { code: 'const state = cy.state();', parserOptions },