From 35abe04760dac4b91b4669fb30d09161ceeaf7ae Mon Sep 17 00:00:00 2001 From: Martyn Chamberlin Date: Tue, 28 Jul 2020 16:00:38 -0500 Subject: [PATCH 1/4] Fix bug with iFrame focus --- packages/driver/src/cy/focused.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/driver/src/cy/focused.js b/packages/driver/src/cy/focused.js index e0c3c224ef4c..0203c1785b3f 100644 --- a/packages/driver/src/cy/focused.js +++ b/packages/driver/src/cy/focused.js @@ -91,7 +91,7 @@ const create = (state) => { // store the current focused element // since when we call .focus() it will change - const $focused = getFocused() + const $focused = getFocused(el.ownerDocument) let hasFocused = false @@ -220,8 +220,8 @@ const create = (state) => { return false } - const getFocused = () => { - const { activeElement } = state('document') + const getFocused = (document = state('document')) => { + const { activeElement } = document if ($dom.isFocused(activeElement)) { return $dom.wrap(activeElement) From b0e6ab0e8b4d8418a77b4379c50a543a035a7e2e Mon Sep 17 00:00:00 2001 From: Chris Breiding Date: Wed, 29 Jul 2020 09:44:56 -0400 Subject: [PATCH 2/4] add test for iframe input focus fix --- packages/driver/cypress/fixtures/issue-8111-inner.html | 4 ++++ packages/driver/cypress/fixtures/issue-8111-outer.html | 1 + .../cypress/integration/commands/actions/type_spec.js | 10 ++++++++++ packages/driver/src/cy/focused.js | 7 +++++-- 4 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 packages/driver/cypress/fixtures/issue-8111-inner.html create mode 100644 packages/driver/cypress/fixtures/issue-8111-outer.html diff --git a/packages/driver/cypress/fixtures/issue-8111-inner.html b/packages/driver/cypress/fixtures/issue-8111-inner.html new file mode 100644 index 000000000000..1394a7ef8fd2 --- /dev/null +++ b/packages/driver/cypress/fixtures/issue-8111-inner.html @@ -0,0 +1,4 @@ + + diff --git a/packages/driver/cypress/fixtures/issue-8111-outer.html b/packages/driver/cypress/fixtures/issue-8111-outer.html new file mode 100644 index 000000000000..c42ae8edf1e9 --- /dev/null +++ b/packages/driver/cypress/fixtures/issue-8111-outer.html @@ -0,0 +1 @@ +