From 3a7f2a30699055c5fe30d1ae4bb7f78219e6fffc Mon Sep 17 00:00:00 2001 From: Tyler Biethman Date: Mon, 27 Jun 2022 09:25:29 -0500 Subject: [PATCH 1/4] test: Bumping timeout on breadcrumb state checks for Windows --- packages/launchpad/cypress/e2e/global-mode.cy.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/launchpad/cypress/e2e/global-mode.cy.ts b/packages/launchpad/cypress/e2e/global-mode.cy.ts index 991bb5219e15..2d0bffd0b0b5 100644 --- a/packages/launchpad/cypress/e2e/global-mode.cy.ts +++ b/packages/launchpad/cypress/e2e/global-mode.cy.ts @@ -152,7 +152,8 @@ describe('Launchpad: Global Mode', () => { it('updates breadcrumb when selecting a project and navigating back', () => { const getBreadcrumbLink = (name: string, options: { disabled: boolean } = { disabled: false }) => { - return cy.findByRole('link', { name }).should('have.attr', 'aria-disabled', options.disabled ? 'true' : 'false') + // The timeout is increased to account for variability in configuration load times in CI. + return cy.findByRole('link', { name, timeout: 10000 }).should('have.attr', 'aria-disabled', options.disabled ? 'true' : 'false') } const resetSpies = () => { From 36df684763d7efffce5333442df4bf79ddd0909d Mon Sep 17 00:00:00 2001 From: Tyler Biethman Date: Mon, 27 Jun 2022 10:07:45 -0500 Subject: [PATCH 2/4] todos project was missing component index but has component testing configured --- .../todos/cypress/support/component-index.html | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 system-tests/projects/todos/cypress/support/component-index.html diff --git a/system-tests/projects/todos/cypress/support/component-index.html b/system-tests/projects/todos/cypress/support/component-index.html new file mode 100644 index 000000000000..ac6e79fd83df --- /dev/null +++ b/system-tests/projects/todos/cypress/support/component-index.html @@ -0,0 +1,12 @@ + + + + + + + Components App + + +
+ + \ No newline at end of file From 43a33903bd8f18e710a56ead57d24b8e03e804fa Mon Sep 17 00:00:00 2001 From: Tyler Biethman Date: Mon, 27 Jun 2022 11:28:24 -0500 Subject: [PATCH 3/4] Adding key to links to ensure attrs are cleaned up/reset --- .../frontend-shared/src/gql-components/HeaderBarContent.vue | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/frontend-shared/src/gql-components/HeaderBarContent.vue b/packages/frontend-shared/src/gql-components/HeaderBarContent.vue index 72b23192b213..66abf2d0f13a 100644 --- a/packages/frontend-shared/src/gql-components/HeaderBarContent.vue +++ b/packages/frontend-shared/src/gql-components/HeaderBarContent.vue @@ -27,6 +27,7 @@ Date: Mon, 27 Jun 2022 12:06:43 -0500 Subject: [PATCH 4/4] Coercing boolean keys to strings to match vue key types --- .../frontend-shared/src/gql-components/HeaderBarContent.vue | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/frontend-shared/src/gql-components/HeaderBarContent.vue b/packages/frontend-shared/src/gql-components/HeaderBarContent.vue index 66abf2d0f13a..fa5be39dd581 100644 --- a/packages/frontend-shared/src/gql-components/HeaderBarContent.vue +++ b/packages/frontend-shared/src/gql-components/HeaderBarContent.vue @@ -26,8 +26,9 @@
  • + +