-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade extract-zip to address vulnerability #6845
Conversation
Versions of extract-zip before `1.6.8` depended on a vulnerable version of `minimist` via `mkdirp`: max-mapper/extract-zip#85 (comment) Minimist vulnerability: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Looks like updated lock file is missing from the PR. |
@khitrenovich thanks, updated! |
Thanks for the merge @jennifer-shehane! Will this be released with |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Reference: #6793
User facing changelog
Versions of extract-zip before
1.6.8
depended on a vulnerable version ofminimist
viamkdirp
:max-mapper/extract-zip#85 (comment)
Minimist vulnerability: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
How has the user experience changed?
Less security vulnerabilities.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?