Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect TRAVIS_BUILD_WEB_URL from travis for potential use to fix wrong travis links in Dashboard. #6808

Closed
jennifer-shehane opened this issue Mar 23, 2020 · 2 comments · Fixed by #6809
Closed

Collect TRAVIS_BUILD_WEB_URL from travis for potential use to fix wrong travis links in Dashboard. #6808

jennifer-shehane opened this issue Mar 23, 2020 · 2 comments · Fixed by #6809
Assignees
@jennifer-shehane
Labels
CI General issues involving running in a CI provider Cypress Cloud Feature request or issue in Cypress Cloud, not App pkg/server This is due to an issue in the packages/server directory

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Mar 23, 2020 •
edited
Loading

Current behavior:

Currently we generate the Travis CI URL in the Dashboard and it is sometimes wrong - notably going to the travis.com when the repo may be open source (and should go to travis.org). Related services issue: https://github.com/cypress-io/cypress-services/issues/734

Desired behavior:

There was a mention that perhaps that Dashboard could handle this if the Test Runner collected the TRAVIS_BUILD_WEB_URL outlined in https://docs.travis-ci.com/user/environment-variables/#default-environment-variables so we should just collect that in the TR.

Versions

4.2.0
@jennifer-shehane jennifer-shehane added external: dashboard pkg/server This is due to an issue in the packages/server directory stage: ready for work The issue is reproducible and in scope labels Mar 23, 2020
@jennifer-shehane jennifer-shehane self-assigned this Mar 23, 2020
@jennifer-shehane jennifer-shehane mentioned this issue Mar 23, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Mar 23, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 24, 2020

The code for this is done in cypress-io/cypress#6809, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Mar 24, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 30, 2020

Released in 4.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 30, 2020
@jennifer-shehane jennifer-shehane added CI General issues involving running in a CI provider Cypress Cloud Feature request or issue in Cypress Cloud, not App and removed CI: travis labels Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-shehane jennifer-shehane

Labels
CI General issues involving running in a CI provider Cypress Cloud Feature request or issue in Cypress Cloud, not App pkg/server This is due to an issue in the packages/server directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collect travisBuildWebUrl from TR cypress-io/cypress
1 participant
@jennifer-shehane