Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bundled typescript from packages/server #6051

Closed
sainthkh opened this issue Dec 27, 2019 · 4 comments
Closed

Remove bundled typescript from packages/server #6051

sainthkh opened this issue Dec 27, 2019 · 4 comments
Labels
process: dependencies Related to internal dependencies type: performance 🏃‍♀️ Performance related

Comments

@sainthkh
Copy link
Contributor

Current behavior:

TypeScript is bundled in packages/server because of dependency-tree. It takes about 35MB of space. I should be removed to reduce the bundle size.

Desired behavior:

TypeScript should be removed from the bundle. We need to find ways to replace dependency-tree.

Steps to reproduce: (app code and test code)

npm ls typescript in packages/server.

Versions

develop branch.
@sainthkh sainthkh mentioned this issue Dec 27, 2019
Closed
@sainthkh sainthkh changed the title Removed bundled typescript from packages/server Remove bundled typescript from packages/server Dec 27, 2019
@sainthkh sainthkh mentioned this issue Dec 27, 2019
Closed
@cypress-bot cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label Dec 30, 2019
@jennifer-shehane jennifer-shehane added the process: dependencies Related to internal dependencies label Dec 30, 2019
@sainthkh sainthkh mentioned this issue Mar 26, 2020
Merged
4 tasks
@jennifer-shehane
Copy link
Member

@sainthkh is this still relevant?

@sainthkh
Copy link
Contributor Author

Unfortunately, it is.

@package/server is still bundling typescript because of dependency-tree.

dependency-tree@7.0.2
- filing-cabinet@2.3.1
  - typescript@3.0.3

@flotwig
Copy link
Contributor

flotwig commented Apr 8, 2022

@tgriesser closed this in #20905

@flotwig flotwig closed this as completed Apr 8, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 1, 2022

Released in 10.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: needs investigating Someone from Cypress needs to look at this label Jun 1, 2022
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
process: dependencies Related to internal dependencies type: performance 🏃‍♀️ Performance related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flotwig @jennifer-shehane @sainthkh