Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting only works sometimes (flaky tests) #4656

Closed
dialex opened this issue Jul 5, 2019 · 2 comments
Closed

Blacklisting only works sometimes (flaky tests) #4656

dialex opened this issue Jul 5, 2019 · 2 comments

Comments

@dialex
Copy link

dialex commented Jul 5, 2019

Current behavior:

I had 6 tests, all passed, all stable.

Screenshot 2019-07-03 at 16 25 37

Now I have 20 tests, and previous stable tests are now flaky.

I blacklisted a domain (googlesyndication.com), but sometimes the request is not blacklisted and Cypress times out waiting for a reply. Why?

Am I missing something? Is there a workaround?

Desired behavior:

I want blacklisted domains to be ignored, always.

Versions

Cypress 3.2.0, MacOS 10.14.5, Chrome 75

@flotwig
Copy link
Contributor

flotwig commented Jul 8, 2019

@dialex We've made a lot of network fixes between 3.2.0 and 3.3.2, could you let me know if you still experience this issue in 3.3.2?

If so, could you provide the full debug logs from when you experience the issue?

@dialex
Copy link
Author

dialex commented Jul 9, 2019

I upgraded to 3.3.2 and all tests are passing consistently: I got 5 runs all green, looks promising :)

@dialex dialex closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants