Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for backticks in reporter error messages #3608

Closed
lilaconlee opened this issue Feb 27, 2019 · 6 comments
Closed

Add support for backticks in reporter error messages #3608

lilaconlee opened this issue Feb 27, 2019 · 6 comments
Assignees

Comments

@lilaconlee
Copy link
Contributor

Current behavior:

No markdown support currently, linkify support added in #3457

Desired behavior:

Include support for backticks and escaping so we can use them in error messages.

@lilaconlee
Copy link
Contributor Author

Before merging I need to figure how how to handle escaped values in the console props:
screen shot 2019-02-27 at 2 25 28 pm
screen shot 2019-02-27 at 4 05 29 pm

@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: work in progress labels Mar 12, 2019
@lilaconlee
Copy link
Contributor Author

Blocked by #3629 which bumps snap-shot-it which fixes a bug with escaped backticks. Tried a workaround with 89566e9 replacing backticks with single quotes, but think we should just upgrade.

Tried figuring out the failing tests on the upgrade and couldn't figure it out, @bahmutov said he'd give it a go if he has time.

@lilaconlee
Copy link
Contributor Author

This is now unblocked by snapshot-it 🎉 but now blocked because the snapshot-it changes are gonna every saved snapshot and some of them are failing for me locally on develop (test/e2e/8_reporters_spec.coffee) which I'll see about getting around tomorrow.

@bahmutov
Copy link
Contributor

bahmutov commented Mar 21, 2019 via email

@lilaconlee lilaconlee added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Mar 25, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 28, 2019

The code for this is done in cypress-io/cypress#3694, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member

Closing as part of #3762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants