chore: fix kitchensink windows #30909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/fix_windows_kitchensink
|
| Run status |
|
| Run duration | 16m 04s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
762
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
63.64%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
56
|
Accessibility
96.19%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
196
|
AtofStryker
force-pushed
the
chore/fix_windows_kitchensink
branch
3 times, most recently
from
50b0525 to
adea4eb
Compare
AtofStryker
commented
Jan 22, 2025
| @@ -2769,7 +2779,6 @@ jobs: | |||
| - test-binary-against-rwa: | |||
| repo: cypress-realworld-app | |||
| browser: chrome | |||
| wait-on: http://localhost:3000 | |||
There was a problem hiding this comment.
wasn't actually doing anything as wait-on wasn't defined
AtofStryker
force-pushed
the
chore/fix_windows_kitchensink
branch
from
adea4eb to
7b8e6d3
Compare
AtofStryker
commented
Jan 22, 2025
| @@ -908,10 +908,6 @@ commands: | |||
| description: Pull request number to check out before installing and testing | |||
| type: integer | |||
| default: 0 | |||
| wait-on: | |||
There was a problem hiding this comment.
param defined but isn't actually used
jennifer-shehane
approved these changes
Jan 22, 2025
jennifer-shehane
requested changes
Jan 22, 2025
There was a problem hiding this comment.
@AtofStryker This is failing saying npm is not there. I don't totally understand why the npx wait-on command isn't sufficient.
something else is going on with this job. Going to investigate further |
AtofStryker
force-pushed
the
chore/fix_windows_kitchensink
branch
2 times, most recently
from
3fa8097 to
cc20545
Compare
AtofStryker
force-pushed
the
chore/fix_windows_kitchensink
branch
from
2694b31 to
6eda48f
Compare
|
@jennifer-shehane this should now be working. ultimately if we don't pass anything to the wait-on variable, we shouldn't call the |
jennifer-shehane
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
fixes the issues with
wait-onin thewindows-test-binary-against-kitchensink-chrome.wait-onisn't actually installed by the kitchen sink repo, so we need to install it before invoking it.we also only want to call it if we pass in something to the
wait-onparam. Sincewait-oncauses issues in windows, this step will now bypassSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?