feat: add todomvc example for use in updated scaffolding #481
Conversation
|
|
|
Deploy Preview for cypress-example-kitchensink ready! Built with commit b66aa3f https://deploy-preview-481--cypress-example-kitchensink.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
panzarino
changed the title
There was a problem hiding this comment.
Just a few little things. Otherwise it looks good.
Also, this probably shouldn't be on you, but this repo should be running against Cypress 7.3.0, since we want to merge it up to cypress develop. This PR looks like a mess #480
| // we need to type the enter key as well in order to submit the input. | ||
| // This input has a data-test attribute so we'll use that to select the | ||
| // element in accordance with best practices: | ||
| // https://on.cypress.io/best-practices#Selecting-Elements |
There was a problem hiding this comment.
Might want to make a specific on link for this, since the anchor link names sometimes change and this link would break in peoples scaffolded tests.
| // https://on.cypress.io/best-practices#Selecting-Elements | |
| // https://on.cypress.io/best-practices#Selecting-Elements |
|
|
||
| // Now that we've checked the button, we can go ahead and make sure | ||
| // that the list element is now marked as completed. | ||
| // Again we'll use contains to find the <label> element and then use the `parents` command |
There was a problem hiding this comment.
| // Again we'll use contains to find the <label> element and then use the `parents` command | |
| // Again we'll use 'contains' to find the <label> element and then use the `parents` command |
|
Oh I think the 7.3.0 branch was ran when the download server was down. Gonna rerun it all. |
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
…kitchensink into add-todo-mvc
|
@jennifer-shehane Added suggestions - PR for |
panzarino
changed the title
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds a modified version of todomvc for use in updated scaffolding
Depends on changes in cypress-io/cypress#15826