Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if composer.lock should be tracked in Git (or stay with composer.lock in .gitignore) #597

Closed
marclaporte opened this issue Aug 14, 2022 · 6 comments

Comments

@marclaporte
Copy link
Member Author

Related chat thread on Gitter: https://gitter.im/cypht-org/community?at=62fa629511a6a83d040e77fb

@Tea23
Copy link

Tea23 commented Sep 26, 2022

Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands composer check-platform-reqs, composer install expects a lockfile to be present.

I'm a neophyte with composer and stuff, so I worked around this by replacing the commands in pre-install and pre-update with echo hi and then composer install correctly generated the lockfile.

@kk6mrp
Copy link
Contributor

kk6mrp commented Oct 1, 2022

Removing composer.lock has caused an issue with install. As composer.json contains the pre install and pre update commands composer check-platform-reqs, composer install expects a lockfile to be present.

I'm having this same issue when trying to update.

@marclaporte
Copy link
Member Author

@marclaporte
Copy link
Member Author

marclaporte commented Jul 7, 2023

For the record, composer.lock was removed here: 131daac

And it's highly likely we will resume maintaining composer.lock in Git

@marclaporte
Copy link
Member Author

composer.lock is now back in the code base:
58f007a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants