From 678c04970760f5be76e13dde9f84dd85d4465e37 Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Tue, 22 Oct 2024 23:55:21 +0400 Subject: [PATCH 1/2] ci: fix MSSQL initialization in CI --- .github/workflows/ci-mssql.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-mssql.yml b/.github/workflows/ci-mssql.yml index e6583762..a37f3a98 100644 --- a/.github/workflows/ci-mssql.yml +++ b/.github/workflows/ci-mssql.yml @@ -26,18 +26,21 @@ jobs: - php: '8.0' extensions: pdo, pdo_sqlsrv mssql: 'server:2017-latest' - - php: '8.0' - extensions: pdo, pdo_sqlsrv - mssql: 'server:2019-latest' - php: '8.1' extensions: pdo, pdo_sqlsrv mssql: 'server:2019-latest' + odbc-version: 18 + flag: "-C" - php: '8.2' extensions: pdo, pdo_sqlsrv mssql: 'server:2019-latest' + odbc-version: 18 + flag: "-C" - php: '8.3' extensions: pdo, pdo_sqlsrv mssql: 'server:2019-latest' + odbc-version: 18 + flag: "-C" services: mssql: @@ -48,7 +51,7 @@ jobs: MSSQL_PID: Developer ports: - 11433:1433 - options: --name=mssql --health-cmd="/opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P 'SSpaSS__1' -Q 'SELECT 1'" --health-interval=10s --health-timeout=5s --health-retries=3 + options: --name=mssql --health-cmd="/opt/mssql-tools${{ matrix.odbc-version }}/bin/sqlcmd ${{ matrix.flag }} -S localhost -U SA -P 'SSpaSS__1' -Q 'SELECT 1'" --health-interval=10s --health-timeout=5s --health-retries=5 steps: - name: Checkout From ec267780276741d94545b5f270fef03469c1f52c Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Wed, 23 Oct 2024 00:35:07 +0400 Subject: [PATCH 2/2] tests: improve docker compose file: remove `restart: always`, fix mysql --- tests/docker-compose.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/docker-compose.yml b/tests/docker-compose.yml index 0e3997f1..ae0c677f 100644 --- a/tests/docker-compose.yml +++ b/tests/docker-compose.yml @@ -5,7 +5,6 @@ version: "3" services: sqlserver: image: mcr.microsoft.com/mssql/server:2019-latest - restart: always ports: - "11433:1433" environment: @@ -14,8 +13,6 @@ services: mysql_latest: image: mysql:latest - restart: always - command: --mysql-native-password=ON ports: - "13306:3306" environment: @@ -25,7 +22,6 @@ services: postgres: image: postgres:12 - restart: always ports: - "15432:5432" environment: