Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features requset: support garmin-China(garmin.cn) and download activities after a certain time. #21

Closed
yihong0618 opened this issue Oct 12, 2020 · 5 comments

Comments

@yihong0618
Copy link
Contributor

yihong0618 commented Oct 12, 2020

Hi,
thank you for your great job for this repo.

  1. Beacause I am working on running_page to support garminconnect
    I run in China, and there's a different api for Chinese runners, like https://connect.garmin.cn/modern/
    except for the cn instead of com, others are the same.
    like below
    image
    can we offer a parameter like cn for Chinese runners?
    something like this
client = Garmin(YOUR_EMAIL, YOUR_PASSWORD, is_cn=True)
  1. because I download every day gpx using GitHub Actions so if we can only download the activities after a certain time will be wonderful. like my runtastic repo do.

Can I take a pr for these features?

@cyberjunky
Copy link
Owner

@yihong0618 If you want to contribute with a PR, please do so! If not let me know, and I can implement it, when I find some time.

@yihong0618
Copy link
Contributor Author

@cyberjunky
Got it, will do this in this weekend thank you~

@yihong0618
Copy link
Contributor Author

@cyberjunky
This PR support connect.garmin.cn

@yihong0618
Copy link
Contributor Author

I think there is no need to support after a certain
Because we hava get_activities_by_date now.

So this issue can be closed

@cyberjunky
Copy link
Owner

@yihong0618 I see you have used my code in your project and made it async, nice. Wanted to do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants