Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GoConvey #224

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Remove GoConvey #224

merged 2 commits into from
Dec 10, 2021

Conversation

szh
Copy link
Contributor

@szh szh commented Nov 19, 2021 •
edited
Loading

What does this PR do?

  • Rewrites test that used GoConvey to use a lightweight assertions library and native golang testing
  • Refactor tests in secretsyml/secretsyml_test.go to reduce code duplication

What ticket does this PR close?

Resolves N/A

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@szh szh self-assigned this Nov 19, 2021
@szh szh marked this pull request as ready for review November 19, 2021 16:07
@szh szh requested a review from a team as a code owner November 19, 2021 16:07
diverdane
diverdane reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question about how assert.EqualValues() works.

diverdane
diverdane approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@szh szh merged commit ddb62bc into main Dec 10, 2021
@szh szh deleted the remove-goconvey branch December 10, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diverdane diverdane diverdane approved these changes

Assignees

@szh szh

Labels
component/summon kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szh @diverdane