Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch support #9

Closed
ben-fussell opened this issue May 20, 2023 · 2 comments · Fixed by #10 or #12
Closed

Add multi-arch support #9

ben-fussell opened this issue May 20, 2023 · 2 comments · Fixed by #10 or #12
Labels
patch Fixes

Comments

@ben-fussell
Copy link

@cybcon - first, thank you for publishing your modbus tools!

It would be super helpful to be able to run the modbus-client docker image on an arm device, so would it be possible to update the build-and-push action steps to something like this?

    steps:
      - name: Checkout GIT repository
        uses: actions/checkout@v3
      - name: Get the application version
        id: application-version
        run: |
          image_version=$(grep "^LABEL site.local.program.version=" Dockerfile | cut -d= -f2 | sed -e 's/"//g')
          if [ -z "${image_version}" ]; then
            echo "ERROR: unable to detect version number!" >&2
            exit 1
          fi
          echo "tag=${image_version}" >> $GITHUB_OUTPUT
      - name: Set up QEMU
        uses: docker/setup-qemu-action@v2
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v2
      - name: Login to container registry
        uses: docker/login-action@v2
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_PASSWORD }}
      - name: Build and push
        uses: docker/build-push-action@v4
        with:
          push: true
          context: .
          platforms: linux/amd64, linux/arm64
          tags: oitc/modbus-client:${{steps.application-version.outputs.tag}}
@cybcon
Copy link
Owner

cybcon commented May 24, 2023

Hi @ben-fussell,
Thank you for your suggestion. I added now your code to the pipeline.
You will find now Linux amd64 and Linux arm64 on docker Hub - Version 1.0.11 ist the correct one.

It will be greate if you can test the arm64 version if all is working well.

Best regards,
Michael

@cybcon
Copy link
Owner

cybcon commented Jun 6, 2023

arm64 implemented for client and server and functionality validated today

@cybcon cybcon closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Fixes
Projects
None yet
2 participants