fix: crash when switching screens frequently #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
+ Coverage 63.68% 65.03% +1.35%
==========================================
Files 140 148 +8
Lines 5502 6127 +625
==========================================
+ Hits 3504 3985 +481
- Misses 1998 2142 +144 ☔ View full report in Codecov by Sentry. |
mrehan27
approved these changes
Oct 1, 2024
I believe you are trying to say, that it won't wait for the first dispatcher to complete in case another dispatcher is launcher from a middleware, if so that should be perfectly alright, in android its working like that too and redux is supposed to work in that fashion as well. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
## [3.4.1](3.4.0...3.4.1) (2024-10-01) ### Bug Fixes * crash when switching screens frequently ([#820](#820)) ([62268a4](62268a4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/customerio/issue/MBL-573/in-app-message-delivery-issue
changes:
dispatcherfromDigraphwe are accessing it very frequently when the screen changes very frequently, so instead of fetching/creating an instance every time, let's utilize the the instance provided by middleware.